Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Won't work if we use .focus() without arguments. #1

Closed
lakesare opened this issue May 30, 2019 · 3 comments
Closed

Won't work if we use .focus() without arguments. #1

lakesare opened this issue May 30, 2019 · 3 comments
Assignees
@calvellido
Labels
bug Something isn't working

Comments

@lakesare
Copy link

lakesare commented May 30, 2019 •
edited
Loading

Nice library! Adding if (args && args.preventScroll) {} will help, right now it fails if we use .focus().
@lakesare
Copy link
Author

lakesare commented May 30, 2019 •
edited
Loading

And createElement will always fail, it should be document.createElement.

@calvellido calvellido self-assigned this May 30, 2019
calvellido added a commit that referenced this issue May 30, 2019
@calvellido
Fix bad checking and native function call
dd40321 
As sugested in #1
@calvellido calvellido mentioned this issue May 30, 2019
Merged
calvellido added a commit that referenced this issue May 30, 2019
@calvellido
Fix bad checking and native function call (#2)
5aa92d8 
As sugested in #1
@calvellido
Copy link
Owner

Nice, thanks so much @lakesare!

I've addressed your comments in #2, please let me know if you feel we can improve it further, cheers!

@calvellido
Copy link
Owner

Closed through #2

@calvellido calvellido added the bug Something isn't working label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvellido calvellido

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lakesare @calvellido