reproducing ember require bug

[thlorenz]

• should replace require jquery and require handlebars
• does not do so wrapped or unwrapped
• generated files are actual results, dereq files are expected

Should not be actually merged (ember is huge) unless you are fine with slow tests and .npmignore the test directory.
Otherwise just use it to reproduce the issue.

[calvinmetcalf]

To summarize from our irc chat for others this is a feature not a bug, as
derequire only rewrites requires that are bound to functional arguments.
The idea is to rename calls that browserify has already dealt with, you
need something for earlier in the transform stage.
On Feb 25, 2014 4:09 PM, "Thorsten Lorenz" notifications@github.com wrote:

• should replace require jquery and require handlebars
• does not do so wrapped or unwrapped
• generated files are actual results, dereq files are expected

Should not be actually merged (ember is huge) unless you are fine with
slow tests and .npmignore the test directory.

Otherwise just use it to reproduce the issue.

You can merge this Pull Request by running

git pull https://github.com/thlorenz/derequire ember-bug

Or view, comment on, or merge it at:

#9
Commit Summary

• reproducing ember require bug

File Changes

• A test/ember.dereq.jshttps://github.com/reproducing ember require bug #9/files#diff-0(40596)
• A test/ember.generated.jshttps://github.com/reproducing ember require bug #9/files#diff-1(40596)
• A test/ember.jshttps://github.com/reproducing ember require bug #9/files#diff-2(40596)
• A test/ember.wrapped.dereq.jshttps://github.com/reproducing ember require bug #9/files#diff-3(40599)
• A test/ember.wrapped.generated.jshttps://github.com/reproducing ember require bug #9/files#diff-4(40599)
• M test/test.jshttps://github.com/reproducing ember require bug #9/files#diff-5(28)

Patch Links:

• https://github.com/calvinmetcalf/derequire/pull/9.patch
• https://github.com/calvinmetcalf/derequire/pull/9.diff

Reply to this email directly or view it on GitHubhttps://github.com//pull/9
.

[thlorenz]

Thanks for clearing that up.