Updated to preview api version and reran all tests. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runefa
requested review from
calvinsID,
panchagnula and
StrawnSC
as code owners
3 tasks
StrawnSC
reviewed
Aug 25, 2022
Co-authored-by: Silas Strawn <strawnsc@gmail.com>
runefa
added a commit
that referenced
this pull request
Sep 15, 2022
* initial no dockerfile support for up * bump version * add to help text, history text * Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502) * pass target port to ACR task; add better error information * bump version * fix bug with containerapp create * add test case * bump version * Updated to preview api version and reran all tests. (#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <strawnsc@gmail.com> Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> Co-authored-by: Silas Strawn <strawnsc@gmail.com> * resolve anthony's comments * Revert "`az containerapp up`: Support No Dockerfile Scenario" * Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario"" * Added custom domain support to env create. * Updated param help group text. * Added test. * Wrote env update, wrote test for env update with custom domains. * Minor update. * Added help to env update. Co-authored-by: Silas Strawn <strawnsc@gmail.com> Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.