Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

well-formed: done signals for a group cannot depend on component's input signals #624

Closed
wants to merge 3 commits into from

Conversation

rachitnigam
Copy link
Contributor

@rachitnigam
Copy link
Contributor Author

Hm, I'm starting to think that this might not actually be the right solution. This doesn't leave us a direct way to pass memories by reference. A group that wants to use a memory by reference needs to add a register to store the done signal.

I'd like to get input from @sampsyo @EclecticGriffin and try to formalize the restriction enforced by well-formed and what the principle behind it is.

@rachitnigam rachitnigam added the Status: Discussion needed Issues blocked on discussion label Aug 30, 2021
@rachitnigam
Copy link
Contributor Author

We've decided that components should take at least one cycle and a future implementation of combinational primitives will allow them to take less than one cycle. The specific problem with the original TCAM implementation was that it was using a combinational component which currently is not supported by the compilation flow.

@rachitnigam rachitnigam closed this Oct 7, 2021
@rachitnigam rachitnigam deleted the tcam-fix branch October 7, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion needed Issues blocked on discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tdcc: Invalid code generated when done depends on input signal
1 participant