Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

well-formed: done signals for a group cannot depend on component's input signals #624

Closed
wants to merge 3 commits into from
Closed

well-formed: done signals for a group cannot depend on component's input signals #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30e1496
match_element does not use outside done signal
rachitnigam Aug 6, 2021
ed7cd09
check if groups done signal depends on components input signal. Fixes…
rachitnigam Aug 6, 2021
dd78d4a
fix tcam implementation
rachitnigam Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions calyx/src/passes/well_formed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,34 @@ impl Visitor for WellFormed {
for group_ref in comp.groups.iter() {
let group = group_ref.borrow();
let gname = group.name();
let mut count = 0;
// Find an assignment writing to this group's done condition.
let done = group.assignments.iter().find(|assign| {
group.assignments.iter().filter(|assign| {
let dst = assign.dst.borrow();
dst.is_hole()
&& dst.name == "done"
&& dst.get_parent_name() == gname
});
if done.is_none() {
}).try_for_each(|assign| {
// Increment the number of writes to the done signal.
count += 1;
// Check if the done signal depends on the input port.
let src = assign.src.borrow();
if let ir::PortParent::Cell(cell_wref) = &src.parent {
if matches!(
cell_wref.upgrade().borrow().prototype,
ir::CellType::ThisComponent
) {
let msg = gname.fmt_err(&format!(
"Group's done signal depends on component's input port {}.{}",
comp.name,
src.name
));
return Err(Error::MalformedStructure(msg))
}
}
Ok(())
})?;
if count == 0 {
return Err(Error::MalformedStructure(gname.fmt_err(
&format!(
"No writes to the `done' hole for group `{}'",
Expand Down
Loading