Enhancement/incremental community fields #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jectives loading and error
lucca65
requested changes
Sep 29, 2021
lucca65
approved these changes
Sep 29, 2021
| ) | ||
| community.objectives | ||
| |> List.head | ||
| List.find (.id >> (==) model.objectiveId) objectives |
There was a problem hiding this comment.
took a minute to got what was going there >> operator is weird
There was a problem hiding this comment.
Yeah, point-free can be confusing sometimes.
In this case I kind of like how it reads if you just ignore all the punctuation:
find [something where] id == model.objectiveId
Merged
This was referenced Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR close
Closes #640
Changes Proposed ( a list of new changes introduced by this PR)
BroadcastMsg:CommunityFieldLoadeduploadseobjectivesnão são mais carregados junto com a comunidade. Podemos usar aBroadcastMsgacima para pedir aoLoggedInfazer uma query e pegar esses camposLista de todos os campos afetados:
Esse PR estabelece uma boa estrutura para termos mais campos que podem ser carregados separados da comunidade. Para adicionar um novo campo nesse estilo:
Community.Modelcom um tipo deRemoteData (Graphql.Http.Error field) fieldField. O nome deve ser composto do nome do campo seguido porField(e.g.ObjectivesField)FieldValue. O nome deve ser composto do nome do campo seguido porValue, e possuir o valor do campo (e.g.ObjectivesValue (List Objective))setFieldValue,setFieldAsLoading,isFieldLoadingemaybeFieldValue)Páginas podem solicitar o campo usando as mensagens
LoggedIn.External:RequestedCommunityField Community.Fieldrecebe umCommunity.Field, e verifica se aselectedCommunitydeloggedInjá possui o campo. Se sim, manda o valor por umaBroadcastMsg. Se não, executa uma query para buscar o campo e envia umaBroadcastMsgquando receber o resultado.RequestedReloadCommunityFieldé similar à mensagem acima, mas sempre executa a query para buscar o campo. Útil para forçar o reload de algum campo.Para receber o campo, devem usar um
receiveBroadcast, fazendo pattern match emLoggedIn.CommunityFieldLoadede o campo desejado (e.g.LoggedIn.CommunityFieldLoaded community (Community.Objectives objectives)). O objetocommunityé repassado para evitar estados impossíveis, onde o campo está carregado, mas a comunidade não.How to test ( a list of instructions on how to test this PR)