Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified search wiki test #262

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Modified search wiki test #262

merged 2 commits into from
Aug 29, 2023

Conversation

HalberdOfPineapple
Copy link
Member

Description

Modified the test tests_search_wiki_with_ambiguity by directly setting expected_output to be the summary of entity New York (state). By doing this, this test can test whether the function does find the correct term and accurately check the summary content.

Motivation and Context

Why is this change required? What problem does it solve?
close #260

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

Copy link
Collaborator

@dandansamax dandansamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MorphlingEd. LGTM!

@HalberdOfPineapple HalberdOfPineapple merged commit 71d466d into master Aug 29, 2023
10 checks passed
@HalberdOfPineapple HalberdOfPineapple deleted the fix_wiki_test branch August 29, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] test tests_search_wiki_with_ambiguity fails from time to time
3 participants