Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] test tests_search_wiki_with_ambiguity fails from time to time #260

Closed
2 of 3 tasks
dandansamax opened this issue Aug 28, 2023 · 1 comment · Fixed by #262
Closed
2 of 3 tasks

[BUG] test tests_search_wiki_with_ambiguity fails from time to time #260

dandansamax opened this issue Aug 28, 2023 · 1 comment · Fixed by #262
Assignees
Labels
bug Something isn't working

Comments

@dandansamax
Copy link
Collaborator

Required prerequisites

What version of camel are you using?

0.1.0

System information

pass

Problem description

# test/functions/test_search_functions.py::tests_search_wiki_with_ambiguity()

def tests_search_wiki_with_ambiguity():
    expected_output = (
        "New York, often called New York State, is a state in the"
        " Northeastern United States. A Mid-Atlantic state, New York"
        " borders New England, and has an international border with Canada."
        " With almost 19.7 million residents, it is the fourth-most populous "
        "state in the United States and seventh-most densely populated as of "
        "2022. New York is the 27th-largest U.S. state by area, with a total "
        "area of 54,556 square miles (141,300 km2).New York has a varied "
        "geography. The southeastern part of the state, known as Downstate, "
        "encompasses New York City (the most populous city in the United "
        "States), Long Island (the most populous island in the United States)"
        ", and the lower Hudson Valley.")
    assert search_wiki("New York") == expected_output

This test should be removed or modified since wikipeida updates from time to time, which crashing the test.

Reproducible example code

pass

Traceback

No response

Expected behavior

No response

Additional context

No response

@dandansamax dandansamax added the bug Something isn't working label Aug 28, 2023
@HalberdOfPineapple
Copy link
Member

Have submitted a new PR for this problem. We can simply define expect_output by the summary of entity New York (state) to validate the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants