Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent example use case to generate query, positive and negative examples #451

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

zechengz
Copy link
Member

@zechengz zechengz commented Mar 4, 2024

Description

Add an agent example use case to generate query, positive and negative docs example which can be used by text embedding model (text encoder) contrastive learning.

Also add the response_format to camel/configs/openai_config.py, which can force the model to generate json object etc.

Motivation and Context

Recently there is a good paper [link] published which uses "agent" to generate tasks and corresponding query, positive and (hard) negative document examples. These document examples can then be used for text embedding model finetuning (contrastive learning). Text encoders use this method achieve quite good text embedding performance on the MTEB leaderboard, including SFR-Embedding-Mistral and e5-mistral-7b-instruct etc.

The whole generation includes two steps.

One is task generation:
image
Another one is document generation:
image

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Create a new EMBEDDING task type
  • Create a new prompt for the EMBEDDING task type
  • Create example that includes task generation and single agent query, positive and negative documents generation

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@zechengz zechengz added Prompt Related to camel prompts Example labels Mar 4, 2024
@zechengz zechengz requested a review from lightaime March 4, 2024 05:10
@zechengz zechengz self-assigned this Mar 4, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 4, 2024
Copy link

coderabbitai bot commented Mar 4, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ZIYU-DEEP
Copy link
Contributor

ZIYU-DEEP commented Mar 18, 2024

My apologies for the late review! Just had a look over the feature and it is looking great overall!

Just a minor point to consider for the examples:

  • Adding a reference to the original paper could be helpful for users to understand the background and application better. Maybe we can add such information in the docstring or add a small README in examples/embedding?

I am still getting my feet wet with code reviews for open-source projects, so if you see anything off in my suggestions, just hit me back. Thanks a lot!

@zechengz zechengz requested a review from a team June 17, 2024 06:54
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zechengz! The example is awesome. I really like it!

nit: some naming suggestion to make the name more specific

camel/types/enums.py Outdated Show resolved Hide resolved
camel/prompts/text_embedding.py Outdated Show resolved Hide resolved
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zechengz !

@Wendong-Fan Wendong-Fan merged commit b481c72 into master Jun 20, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the zecheng_embedding_agent branch June 20, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Prompt Related to camel prompts size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Reviewing
Development

Successfully merging this pull request may close these issues.

None yet

4 participants