Only enable the deflate feature of the zip dependency
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got some unrelated build problems with `zstd-safe`, with `cameleon` pulling it to our dependencies. I then realized that the `zstd` compression isn't needed in cameleon. The GenICam GenTL 1.6 (PDF) spec says under 4.1.2 XML Description: > Supported formats are: > - Uncompressed XML description files > - Zip-compressed XML description files. The compression methods used are DEFLATE and STORE as described in RFC 1951. ...so only enable the `deflate` feature on `zip`.
strohel
changed the title
zip dependency leanerdeflate feature of the zip dependency
Y-Nak
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some unrelated build problems with
zstd-safe, withcameleonpulling it to our dependencies. I then realized that thezstdcompression isn't needed in cameleon.The GenICam GenTL 1.6 spec says under 4.1.2 XML Description:
...so only enable the
deflatefeature onzip.test_all.shis passed.fix #{ISSUE_NUMBER}if the corresponding issue exists.## Changelogsection. If the change is for only internal use, please writeNoneto the section.Changelog
None