SemType: replace Dimension to support assumed-size #244
+43
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RaoulHC the type change should look something like this -- push and make whatever changes you want here (or make another PR), though most work will be in fortran-vars and other pkgs |
RaoulHC
reviewed
Oct 13, 2022
raehik
force-pushed
the
semtype-array-star
branch
from
40b9593
to
4624c27
Compare
RaoulHC
approved these changes
Oct 17, 2022
The `TArray` constructor in `SemType` supports "fully-dynamic" arrays and "fully-static" ones, but not assumed-size arrays, which are a holdover from older Fortran standards where only the final dimension is dynamic. We replace the `Dimension` type synonym with a list-like data type in order to support them. Laziness (and thus performance) should be the same.
raehik
force-pushed
the
semtype-array-star
branch
from
4624c27
to
11c9259
Compare
|
Added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TArrayconstructor inSemTypesupports "fully-dynamic" arrays and "fully-static" ones, but not assumed-size arrays, which are a holdover from older Fortran standards where only the final dimension is dynamic. We replace theDimensiontype synonym with a list-like data type in order to support them.