Forward manager env vars to worker #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcanevet
requested review from
cryptobioz and
raphink
and removed request for
cryptobioz
mcanevet
force-pushed
the
forward_env
branch
7 times, most recently
from
9af2653
to
478f6e0
Compare
mcanevet
changed the title
|
Tested on Cattle and it looks like it works fine. |
mcanevet
force-pushed
the
forward_env
branch
from
478f6e0
to
282730b
Compare
mcanevet
force-pushed
the
forward_env
branch
from
282730b
to
c437b67
Compare
Pull Request Test Coverage Report for Build 847
💛 - Coveralls |
cryptobioz
requested changes
Sep 27, 2018
mcanevet
force-pushed
the
forward_env
branch
from
c437b67
to
b0399c0
Compare
cryptobioz
approved these changes
Sep 27, 2018
This was referenced Sep 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to deprecate the AWS and Swift options and remove a lot of code.
Furthermore, as we now have the manager container, we'll easily be able to forward the volumes and secrets mounted on the manager and solve a lot of issues.