Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old params #228

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Cleanup old params #228

merged 1 commit into from
Oct 18, 2018

Conversation

mcanevet
Copy link
Contributor

@mcanevet mcanevet commented Sep 29, 2018 •
edited

Now that #220 is merged, we can do some cleanup.

@coveralls
Copy link

coveralls commented Sep 29, 2018 •
edited

Pull Request Test Coverage Report for Build 960

  • 0 of 10 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 6.699%
Changes Missing Coverage Covered Lines Changed/Added Lines %
engines/duplicity.go 0 1 0.0%
engines/rclone.go 0 1 0.0%
engines/restic.go 0 1 0.0%
orchestrators/cattle.go 0 2 0.0%
orchestrators/kubernetes.go 0 2 0.0%
orchestrators/docker.go 0 3 0.0%
Totals Coverage Status
Change from base Build 958: 0.2%
Covered Lines: 125
Relevant Lines: 1866
💛 - Coveralls

@mcanevet mcanevet changed the title Remove --extra-env parameter Cleanup old params Sep 29, 2018
@mcanevet mcanevet modified the milestone: 1.0.0-alpha6 Oct 4, 2018
@mcanevet mcanevet force-pushed the remove_old_params branch 3 times, most recently from 0002e68 to 8e12b26 Compare October 6, 2018 04:28
@cryptobioz cryptobioz added this to the 1.0.0-alpha8 milestone Oct 16, 2018
@mcanevet mcanevet merged commit 2707cb8 into camptocamp:master Oct 18, 2018
@mcanevet mcanevet deleted the remove_old_params branch October 18, 2018 12:29
@cryptobioz cryptobioz mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcanevet @coveralls @cryptobioz