Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a separate cache for the OGC servers #9911

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Have a separate cache for the OGC servers #9911

merged 1 commit into from
Aug 10, 2022

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jul 6, 2022 •
edited
Loading

Tested on demo, at home throw VPN on my slow new computer
GSLUX-460

Before:
First: 33.6s
Second: 0.7s
After Layer change: 34.6s
After OGC server change: 32.4s

After:
First: 43.6s
Second: 0.9s
After Layer change: 4.1s
After OGC server change: 4.1s (But we should wait that the background task ended, about 20s)

@sbrunner sbrunner changed the title Have a separate cahce for the ogcservers Have a separate cache for the OGC servers Jul 6, 2022
@sbrunner sbrunner force-pushed the cache-ogsservers-gslux-460 branch 26 times, most recently from 7eb16aa to 1e2f030 Compare July 8, 2022 10:15
@sbrunner sbrunner marked this pull request as ready for review July 8, 2022 10:15
arnaud-morvan
arnaud-morvan reviewed Jul 9, 2022
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems really difficult to not depends on theme_view in admin.
But this will block us it at some time we want to put admin in another container.

.prospector.yaml Outdated Show resolved Hide resolved
admin/c2cgeoportal_admin/routes.py Outdated Show resolved Hide resolved
admin/c2cgeoportal_admin/views/ogc_servers.py Outdated Show resolved Hide resolved
admin/c2cgeoportal_admin/views/ogc_servers.py Outdated Show resolved Hide resolved
admin/c2cgeoportal_admin/views/ogc_servers.py Outdated Show resolved Hide resolved
commons/c2cgeoportal_commons/models/main.py Show resolved Hide resolved
geoportal/c2cgeoportal_geoportal/views/theme.py Outdated Show resolved Hide resolved
@arnaud-morvan
Copy link
Member

It might be interesting having some tests, available for discussion on this.

@arnaud-morvan
Copy link
Member

Apparently this PR still contains some anti-patterns that I would like to resolve before merge.
Available for discussion.

@sbrunner sbrunner force-pushed the cache-ogsservers-gslux-460 branch 11 times, most recently from ae2309d to 1d10e98 Compare July 13, 2022 10:14
@sbrunner
Copy link
Member Author

@arnaud-morvan ready for a final review :-)

arnaud-morvan
arnaud-morvan approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the view to refresh OGC Server cache is missing.
Feel free to merge after fix.

geoportal/c2cgeoportal_geoportal/__init__.py Outdated Show resolved Hide resolved
geoportal/c2cgeoportal_geoportal/views/theme.py Outdated Show resolved Hide resolved
geoportal/c2cgeoportal_geoportal/__init__.py Show resolved Hide resolved
@sbrunner sbrunner enabled auto-merge August 9, 2022 11:29
@sbrunner sbrunner merged commit 4191263 into master Aug 10, 2022
@sbrunner sbrunner deleted the cache-ogsservers-gslux-460 branch August 10, 2022 16:20
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan