Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readd support to deactivate auto-sync which was broken by #11 #13

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

lentidas
Copy link
Contributor

@lentidas lentidas commented Jul 19, 2023

Description of the changes

This PR:

  • re-adds the support to deactivate the auto-sync, which was broken by the use of dynamic Terraform blocks on the PR feat!: add support to oboukili/argocd v5 #11. This is not a breaking change, because users can still use the old way of passing an empty map to the app_autosync variable in order do deactivate the auto-sync.

Breaking change

  • No

Tests executed on which distribution(s)

I have not had the chance to test this module, but the changes should not pose any issue since they are really similar to other modules.

@lentidas lentidas requested a review from a team as a code owner July 19, 2023 09:53
@lentidas lentidas changed the title fix/ci: fix autosync deactivation and add chart auto-updater workflow @lentidas fix: readd support to deactivate auto-sync which was broken by #11 Jul 19, 2023
@lentidas lentidas force-pushed the fix_autosync_ci_add_chart_updater branch from 17ae1e3 to ad9d93f Compare July 19, 2023 11:05
@lentidas lentidas changed the title @lentidas fix: readd support to deactivate auto-sync which was broken by #11 fix: readd support to deactivate auto-sync which was broken by #11 Jul 19, 2023
@lentidas lentidas self-assigned this Jul 20, 2023
@lentidas lentidas merged commit 1dd1916 into main Aug 9, 2023
@lentidas lentidas deleted the fix_autosync_ci_add_chart_updater branch August 9, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants