Remove onbuild and go-wrapper from Docker build #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbuild images [0] are deprecated go-wrapper [1] is deprecated [0] docker-library/official-images#2076 [1] docker-library/golang#205
guewen
commented
Feb 18, 2020
| RUN go get -d -v ./... | ||
| RUN go install -v ./... | ||
|
|
||
| FROM debian:buster |
There was a problem hiding this comment.
any preference here?
|
Oops, sorry I didn't notice your PR @guewen and pushed almost exactly the same commit to master... |
|
No problem, I should have send you a direct message before even starting this. Anyway, it didn't take me much time, that I can still credit as learning time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onbuild images are deprecated
go-wrapper is deprecated