New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMF draw feature directive #1001
Conversation
0a7fcd9
to
c428a8e
Compare
Can you rebase please |
* @ngdoc directive | ||
* @ngname gmfEditfeature | ||
*/ | ||
gmf.editfeatureDirective = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If one day we want to edit a real feature (from WFS), edit its attributes for example. Would it be in same directive ?
Is the name editFeature
is well chosen ?
Just one issue I see, the measure should be rounded at 3 significant digits :-) |
|
For example display 591 km instance of 591.54 km in the panel and on the map when the "Display length" is checked, finally the same as the tooltip that's display while drawing :-) |
f8cd417
to
ceac59d
Compare
@fgravin Ready for merge. |
@sbrunner "561 km" already has 3 significant digits. Other examples are 5.42 km or 48.6 km or 7520 km. |
@pgiraud yes it's what's I say, but we get 591.54 km that have 5 significant digits ... |
We will get, now it's corrected :-) |
controller: 'GmfDrawfeatureController', | ||
scope: { | ||
'active': '=gmfDrawfeatureActive', | ||
'map': '=gmfDrawfeatureMap' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<gmfDrawfeatureMap
Perfect just one minor comment. |
Done. |
This PR introduces the
gmf-drawfeature
directive, which allows the user to draw vector features on the map and change their style, geometry, etc. There are still things to do to consider the tool completed.Features
This PR introduces
gmf-drawfeature
directive that combines thengeo-drawfeature
andgmf-featurestyle
directivesIt also contains some bug fixes across the other components used by the directive.
This PR will not introduce
Todo
Live example