Set select style (vertex, halo) in feature helper, used in gmf-drawfeature

[adube]

This PR adds the support of drawing vertex in addition to the original style in the feature helper. The gmf-featurestyle directive uses it, in addition to the gmf-drawfeature one.

Geometries that have the vertex drawn:

• LineString
• Polygon
• Rectangle

Geometries that don't have vertex drawn:

• Circle
• Point
• Text

An additional "halo" style is added to selected features.

As a bonus, this PR also includes the ngeo.interaction.ModifyCircle interaction. Circles are now properly modified.

Todo

• add white border around features
• use square for modify style
• add modify circle interaction
• rebase onto master once GMF draw feature directive #1001 is merged
• code review
• apply reviewer's required corrections
• travis pass

Live example

• http://adube.github.io/ngeo/gmf-drawfeature-vertex/examples/contribs/gmf/drawfeature.html

[adube]

@fgravin Ready for review.

[sbrunner]

Shouldn't be drown on Rectangle... or is it planed to use them to resize the rectangle?

Disabling moving vertex Rectangle and Circle on will come in an other pull request?

[adube]

• resize rectangle: Yes, it will be possible
• moving vertex of Rectangle and Circle: Yes, it will be covered in an other PR

[sbrunner]

OK, tranks :-)

[fgravin]

Regarding @sbrunner comment, it is true that the geometry editing style is a blue point, maybe it should be the same style as the vertixes ?

[adube]

@pgiraud, see previous comment.

[adube]

@fgravin - ping (ready for review)
@pgiraud - ping (regarding sbrunner's comment)

[fgravin]

From my side, the code is ok.
For the look and feel, could you try to add a third style when selected, with a stroke width +=2, to simulate an halo ?

For the other things, see with @pgiraud

[adube]

Halo --> Yep.

[pgiraud]

I finally agree with @fgravin that the blue point is a bit awkward. Can you please make it so it uses the same style as the vertices (black square)?

[adube]

Black square --> Yep.

[adube]

Ready for review.

@pgiraud, because fgravin is not here until next week would you please complete the code review, or find someone who's willing to do it ? Thanks.

See the live demo.

[pgiraud]

The UI/UX looks very good. Hooray!
A nice-to-have future enhancement would be to show the halo when hovering the features.

Giving a look at the code now.

[pgiraud]

The style used here is the same as the style used for vertices. This should be factorized in my opinion.

[pgiraud]

I added minor comments. Otherwise it looks very good.

[adube]

Thanks for the review. I'll apply the required changes and report back.

[adube]

All of the corrections required by the reviewer have been made. Ready for merge.

[pgiraud]

Looks good to me. Merging.