Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add unknown keys in the permalink #2152

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Don't add unknown keys in the permalink #2152

merged 2 commits into from
Jan 10, 2017

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jan 4, 2017

fix #1987

@sbrunner sbrunner force-pushed the permalink-creation branch 5 times, most recently from 82adace to 98d12ce Compare January 5, 2017 16:28
@fredj
Copy link
Member

fredj commented Jan 10, 2017

Will it work when we have to add items in the permalink at application level ? (example floor=2 for the epfl project)

@sbrunner
Copy link
Member Author

I hope yes, you should be able to override the ngeoUsedKeyRegexp value.

@sbrunner sbrunner merged commit 2498bda into 2.1 Jan 10, 2017
@sbrunner sbrunner deleted the permalink-creation branch January 10, 2017 12:38
@ger-benjamin ger-benjamin mentioned this pull request Jan 10, 2017
Closed
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @fredj