Remove white space when no identifier attribute #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
approved these changes
Mar 8, 2017
| .gmf-displayquerywindow-details { | ||
| height: @displayquerywindow-detailed-details-height; | ||
| display: none; | ||
| flex: 1; |
There was a problem hiding this comment.
The line upper is display none... so, this css do somethings ?
Don't you want to use visibility:hidden ?
There was a problem hiding this comment.
it's display: none by default but the div is shown in "detailed" mode (see line 65 where there's a display: block)
There was a problem hiding this comment.
Ok, thanks. lgtm if it looks good in the application
fredj
force-pushed
the
displayquerywindow_extra_space
branch
from
40682b6
to
3179dfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2383