Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove white space when no identifier attribute #2413

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Remove white space when no identifier attribute #2413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 9 additions & 18 deletions contribs/gmf/less/displayquerywindow.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,15 @@
position: relative;
overflow: hidden;
// height with 2em: 1em per text (title, subtitle)
height: calc(3 * @app-margin + @half-app-margin ~"+ 2em");
max-height: 10 * @map-tools-size;
height: calc(4 * @app-margin + @half-app-margin ~"+ 2em");
margin: 0;
transition: 0.3s ease-in all;
.gmf-displayquerywindow-slide-animation {
display: flex;
flex-direction: column;
height: 100%;
width: 100%;
padding: @app-margin @app-margin 0;
padding: @app-margin;
text-align: left;
white-space: nowrap;
overflow: hidden;
Expand All @@ -60,6 +61,9 @@
}
.gmf-displayquerywindow-animation-container-detailed {
height: @displayquerywindow-detailed-header-height + @displayquerywindow-detailed-details-height + @app-margin * 3;
.gmf-displayquerywindow-details {
display: block;
}
}
.gmf-displayquerywindow-next {
.gmf-displayquerywindow-slide-animation {
Expand Down Expand Up @@ -89,21 +93,12 @@
}
}
}
.gmf-displayquerywindow-header {
height: @displayquerywindow-detailed-header-height;
margin-bottom: @app-margin;
p {
margin-bottom: @app-margin;
}
}
.gmf-displayquerywindow-title {
font-weight: bold;
}
.gmf-displayquerywindow-subtitle {
min-height: 1em;
}
.gmf-displayquerywindow-details {
height: @displayquerywindow-detailed-details-height;
display: none;
flex: 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line upper is display none... so, this css do somethings ?
Don't you want to use visibility:hidden ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's display: none by default but the div is shown in "detailed" mode (see line 65 where there's a display: block)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. lgtm if it looks good in the application

line-height: @displayquerywindow-detailed-details-line-height;
overflow-x: hidden;
overflow-y: auto;
Expand All @@ -125,7 +120,6 @@
}
}
.gmf-displayquerywindow-navigate {
margin-top: @app-margin;
border-top: solid 1px @border-color;
height: @map-tools-size;
display: flex;
Expand Down Expand Up @@ -214,8 +208,5 @@
.gmf-displayquerywindow-animation-container-detailed {
height: (@displayquerywindow-detailed-header-height + @displayquerywindow-detailed-details-height / 2 + @app-margin * 3);
}
.gmf-displayquerywindow-details {
height: @displayquerywindow-detailed-details-height / 2;
}
}
}