Improve display window template management #4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The aim is to update the content of the windowComponent at any time, and not only at the onInit of the windowComponent. With this change we can display the content of a component even if it's initialized after the windowComponent. |
|
Thanks a lot for having merged that ! I am really looking forward to see this PR in the next coming GMF version ! |
ger-benjamin
added a commit
that referenced
this pull request
Jan 7, 2019
Fix #4471 - Call the function in watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually @ger-benjamin did that... I leave the complete explanation up to him...
FIX: GEO-1113