Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4471 - Call the function in watcher #4483

Merged
merged 2 commits into from Jan 7, 2019
Merged

Fix #4471 - Call the function in watcher #4483

merged 2 commits into from Jan 7, 2019

Conversation

kalbermattenm
Copy link
Contributor

#4471 is not working, because, IHMO, we need to call the function and not just define it in the watcher.

I tested that in my project and it seems to work.

Could somebody please review that and eventually merge it, because I really need it inside 2.3...

Thanks a lot.

@kalbermattenm
Copy link
Contributor Author

kalbermattenm commented Dec 21, 2018 •
edited

I had to add some CSS to fix scrolling bar issues regarding the template content.

@ger-benjamin ger-benjamin self-requested a review January 7, 2019 07:52
ger-benjamin
ger-benjamin approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, please merge !

@ger-benjamin ger-benjamin merged commit f1800e3 into camptocamp:2.3 Jan 7, 2019
@sbrunner sbrunner added this to the 2.3 milestone Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbermattenm @ger-benjamin @sbrunner