Add info project validator status (flutter#109169)

camsim99 · Aug 10, 2022 · 1c365d0 · 1c365d0
1 parent ad1c4c2
commit 1c365d0
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/packages/flutter_tools/lib/src/commands/validate_project.dart b/packages/flutter_tools/lib/src/commands/validate_project.dart
@@ -76,6 +76,7 @@ class ValidateProject {
       case StatusProjectValidator.error:
         icon = '[✗]';
         break;
+      case StatusProjectValidator.info:
       case StatusProjectValidator.success:
         icon = '[✓]';
         break;

diff --git a/packages/flutter_tools/lib/src/project_validator.dart b/packages/flutter_tools/lib/src/project_validator.dart
@@ -153,25 +153,22 @@ class PubDependenciesProjectValidator extends ProjectValidator {
       }
     }
 
+    final String value;
     if (dependencies.isNotEmpty) {
       final String verb = dependencies.length == 1 ? 'is' : 'are';
-      result.add(
-        ProjectValidatorResult(
-          name: name,
-          value: '${dependencies.join(', ')} $verb not hosted',
-          status: StatusProjectValidator.warning,
-        )
-      );
+      value = '${dependencies.join(', ')} $verb not hosted';
     } else {
-      result.add(
-        const ProjectValidatorResult(
-          name: name,
-          value: 'All pub dependencies are hosted on https://pub.dartlang.org',
-          status: StatusProjectValidator.success,
-        )
-      );
+      value = 'All pub dependencies are hosted on https://pub.dartlang.org';
     }
 
+    result.add(
+       ProjectValidatorResult(
+        name: name,
+        value: value,
+        status: StatusProjectValidator.info,
+      )
+    );
+
     return result;
   }
 

diff --git a/packages/flutter_tools/lib/src/project_validator_result.dart b/packages/flutter_tools/lib/src/project_validator_result.dart
@@ -7,6 +7,7 @@ enum StatusProjectValidator {
   warning,
   success,
   crash,
+  info,
 }
 
 class ProjectValidatorResult {

diff --git a/packages/flutter_tools/test/general.shard/pub_dependencies_project_validator_test.dart b/packages/flutter_tools/test/general.shard/pub_dependencies_project_validator_test.dart
@@ -35,7 +35,7 @@ void main() {
       const String expected = 'All pub dependencies are hosted on https://pub.dartlang.org';
       expect(result.length, 1);
       expect(result[0].value, expected);
-      expect(result[0].status, StatusProjectValidator.success);
+      expect(result[0].status, StatusProjectValidator.info);
     });
 
     testWithoutContext('error when command dart pub deps fails', () async {
@@ -56,7 +56,7 @@ void main() {
       expect(result[0].status, StatusProjectValidator.error);
     });
 
-    testWithoutContext('warning on dependencies not hosted', () async {
+    testWithoutContext('info on dependencies not hosted', () async {
       final ProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
         const FakeCommand(
           command: <String>['dart', 'pub', 'deps', '--json'],
@@ -71,7 +71,7 @@ void main() {
       const String expected = 'dep1, dep2 are not hosted';
       expect(result.length, 1);
       expect(result[0].value, expected);
-      expect(result[0].status, StatusProjectValidator.warning);
+      expect(result[0].status, StatusProjectValidator.info);
     });
   });
 }