Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info project validator status #109169

Merged
merged 2 commits into from Aug 9, 2022
Merged

Add info project validator status #109169

merged 2 commits into from Aug 9, 2022

Conversation

Jasguerrero
Copy link
Contributor

@Jasguerrero Jasguerrero commented Aug 8, 2022 •
edited

Fixes: #107675

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 8, 2022
@Jasguerrero Jasguerrero marked this pull request as ready for review August 8, 2022 19:25
christopherfujino
christopherfujino approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jasguerrero Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2022
@auto-submit auto-submit bot merged commit 5627e0d into flutter:master Aug 9, 2022
This was referenced Aug 10, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
5627e0d1f Add info project validator status (flutter/flutter#109169)
cbd665f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
5627e0d Add info project validator status (flutter/flutter#109169)
4a854e3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
5627e0d Add info project validator status (flutter/flutter#109169)
7308f9d
@Jasguerrero Jasguerrero deleted the project_validator_info_state branch August 10, 2022 17:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
5627e0d Add info project validator status (flutter/flutter#109169)
d764fea
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@Jasguerrero @camsim99
Add info project validator status (flutter#109169)
1c365d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter_tools] ProjectValidators should have a non-pass/fail state
2 participants
@Jasguerrero @christopherfujino