Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark theme support to cm-textfield #36

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Add dark theme support to cm-textfield #36

merged 4 commits into from
Oct 26, 2021

Conversation

huygur
Copy link
Collaborator

@huygur huygur commented Aug 27, 2021

No description provided.

huygur
huygur commented Aug 27, 2021
View reviewed changes
src/components/cm-page/cm-page.scss Outdated
Comment on lines 61 to 72
&.Dark {
background-color: #37383e;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the changes in cm-page is to be able to see light/dark theme in components more clear.

huygur
huygur commented Aug 27, 2021
View reviewed changes
src/components/cm-textfield/cm-textfield.scss
Comment on lines +218 to +369
border-bottom-left-radius: 2px;
border-top-left-radius: 2px;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes here and line 298-299 are to fix the gap between the border and the content for prefix & suffix.
my initial approach was to set overflow:hidden in .inputContainer and completely removing these lines. which made sense at first, but then i realised it also hides the copy tooltip. so this is an alternative fix.

@huygur huygur force-pushed the cm-textfield-dark-theme branch 16 times, most recently from 400973c to 7bc43a1 Compare September 14, 2021 07:01
@alexandertrefz alexandertrefz force-pushed the form-elements branch 4 times, most recently from 6864d05 to 3be705c Compare September 15, 2021 16:33
@alexandertrefz alexandertrefz changed the title support dark theme for cm-textfield Add dark theme support to cm-textfield Sep 15, 2021
@alexandertrefz alexandertrefz changed the base branch from form-elements to master September 16, 2021 06:58
@alexandertrefz alexandertrefz self-assigned this Oct 18, 2021
@alexandertrefz alexandertrefz added this to the v.0.0.18 Release milestone Oct 18, 2021
@huygur huygur force-pushed the cm-textfield-dark-theme branch 5 times, most recently from 8c10907 to d272d2b Compare October 22, 2021 10:47
huygur
huygur commented Oct 22, 2021
View reviewed changes
src/components/cm-textfield/cm-textfield.scss Outdated
}
}

border: solid 1px #7f8289;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this color will be clarified with Nazli

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also some inconsistencies with dark theme border colors.
it seems regular text fields border colors are: #7f8289, disabled looks like: #6d7076. but for some reason 'mixed' state looks like #6d7076 even though its not disabled

huygur
huygur commented Oct 22, 2021
View reviewed changes
src/components/cm-textfield/cm-textfield.scss Outdated
Comment on lines 275 to 289
border: solid 1px #646670;
background-color: #464c50;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these colors will be clarified with Nazli

@alexandertrefz alexandertrefz force-pushed the cm-textfield-dark-theme branch 3 times, most recently from ef2b019 to 3dc4099 Compare October 24, 2021 22:16
@huygur huygur force-pushed the cm-textfield-dark-theme branch 2 times, most recently from d5a9079 to 32b091a Compare October 26, 2021 08:18
@alexandertrefz alexandertrefz merged commit 04d3de1 into master Oct 26, 2021
@alexandertrefz alexandertrefz deleted the cm-textfield-dark-theme branch October 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandertrefz alexandertrefz alexandertrefz approved these changes

Assignees

@alexandertrefz alexandertrefz

Labels
Feature
Projects
None yet
Milestone
v.0.0.18 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@huygur @alexandertrefz @camunda-cloud-bot