Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in ProcessMessageStartEventMessageNameValidator.validateMessageName #5510

Closed
pihme opened this issue Oct 6, 2020 · 3 comments · Fixed by #7764
Closed

NPE in ProcessMessageStartEventMessageNameValidator.validateMessageName #5510

pihme opened this issue Oct 6, 2020 · 3 comments · Fixed by #7764
Assignees
@remcowesterhoud
Labels
kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user support Marks an issue as related to a customer support request

Comments

@pihme
Copy link
Contributor

pihme commented Oct 6, 2020

Describe the bug
Observed as error in production logs.

Expected behavior

  • no NPEs in input validation

Log/Stacktrace
https://console.cloud.google.com/errors/CK-E7ry54eavQA?service=zeebe&time=P7D&project=camunda-cloud-240911

Environment:
Camunda Cloud / Prod / 0.24.2, 0.24.3
@pihme pihme added the kind/bug Categorizes an issue or PR as a bug label Oct 6, 2020
@saig0 saig0 mentioned this issue Nov 12, 2020
Closed
@deepthidevaki deepthidevaki added Status: Needs Priority scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user and removed Status: Needs Triage labels Nov 12, 2020
@deepthidevaki
Copy link
Contributor

Observed this in Camunda cloud/ prod/ 0.25.1

log

Unexpected error while processing resource '****.bpmn'
 "java.lang.NullPointerException: null
	at io.zeebe.engine.processing.deployment.model.validation.ProcessMessageStartEventMessageNameValidator.validateMessageName(ProcessMessageStartEventMessageNameValidator.java:53) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.deployment.model.validation.ProcessMessageStartEventMessageNameValidator.lambda$validate$0(ProcessMessageStartEventMessageNameValidator.java:46) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) ~[?:?]
	at java.util.stream.ReferencePipeline$3$1.accept(Unknown Source) ~[?:?]
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) ~[?:?]
	at java.util.ArrayList$Itr.forEachRemaining(Unknown Source) ~[?:?]
	at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source) ~[?:?]
	at java.util.stream.AbstractPipeline.copyInto(Unknown Source) ~[?:?]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) ~[?:?]
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) ~[?:?]
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluate(Unknown Source) ~[?:?]
	at java.util.stream.ReferencePipeline.forEach(Unknown Source) ~[?:?]
	at io.zeebe.engine.processing.deployment.model.validation.ProcessMessageStartEventMessageNameValidator.validate(ProcessMessageStartEventMessageNameValidator.java:46) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.deployment.model.validation.ProcessMessageStartEventMessageNameValidator.validate(ProcessMessageStartEventMessageNameValidator.java:25) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.model.bpmn.validation.ValidationVisitor.lambda$visit$0(ValidationVisitor.java:51) ~[zeebe-bpmn-model-0.25.1.jar:0.25.1]
	at java.util.ArrayList.forEach(Unknown Source) ~[?:?]
	at io.zeebe.model.bpmn.validation.ValidationVisitor.visit(ValidationVisitor.java:51) ~[zeebe-bpmn-model-0.25.1.jar:0.25.1]
	at io.zeebe.model.bpmn.traversal.TypeHierarchyVisitor.visit(TypeHierarchyVisitor.java:39) ~[zeebe-bpmn-model-0.25.1.jar:0.25.1]
	at io.zeebe.model.bpmn.traversal.ModelWalker.walk(ModelWalker.java:60) ~[zeebe-bpmn-model-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.deployment.transform.BpmnValidator.validate(BpmnValidator.java:41) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.deployment.transform.DeploymentTransformer.transformResource(DeploymentTransformer.java:104) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.deployment.transform.DeploymentTransformer.transform(DeploymentTransformer.java:81) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.deployment.TransformingDeploymentCreateProcessor.processRecord(TransformingDeploymentCreateProcessor.java:71) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.streamprocessor.TypedRecordProcessor.processRecord(TypedRecordProcessor.java:51) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.streamprocessor.ReProcessingStateMachine.lambda$chooseOperationForEvent$5(ReProcessingStateMachine.java:323) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.db.impl.rocksdb.transaction.ZeebeTransaction.run(ZeebeTransaction.java:79) ~[zeebe-db-0.25.1.jar:0.25.1]
	at io.zeebe.engine.processing.streamprocessor.ReProcessingStateMachine.lambda$processUntilDone$2(ReProcessingStateMachine.java:298) ~[zeebe-workflow-engine-0.25.1.jar:0.25.1]
	at io.zeebe.util.retry.ActorRetryMechanism.run(ActorRetryMechanism.java:36) ~[zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.retry.EndlessRetryStrategy.run(EndlessRetryStrategy.java:50) ~[zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.sched.ActorJob.invoke(ActorJob.java:73) [zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.sched.ActorJob.execute(ActorJob.java:39) [zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.sched.ActorTask.execute(ActorTask.java:122) [zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.sched.ActorThread.executeCurrentTask(ActorThread.java:107) [zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.sched.ActorThread.doWork(ActorThread.java:91) [zeebe-util-0.25.1.jar:0.25.1]
	at io.zeebe.util.sched.ActorThread.run(ActorThread.java:204) [zeebe-util-0.25.1.jar:0.25.1]

No impact as far as we know. Broker continues to run without any failure.

@npepinpe
Copy link
Member

npepinpe commented Nov 13, 2020 •
edited
Loading

Prioritized as low as there is little impact to the system, except poor UX at the moment. Note, this would require the upgrade process if we were to back port it as it may change the records being written.

@npepinpe npepinpe added this to the Updatable Workflow Engine milestone Jan 12, 2021
@saig0 saig0 removed this from the Updatable Workflow Engine milestone Mar 4, 2021
@saig0 saig0 mentioned this issue May 17, 2021
Closed
@saig0 saig0 added the support Marks an issue as related to a customer support request label Jul 9, 2021
@saig0
Copy link
Member

saig0 commented Jul 9, 2021

This issue was reported in support for version 1.0.0.

It can be reproduced with the following BPMN process:
zeebe_npe.bpmn

@npepinpe npepinpe added this to Ready in Zeebe Jul 12, 2021
@npepinpe npepinpe moved this from Ready to Planned in Zeebe Jul 22, 2021
@remcowesterhoud remcowesterhoud self-assigned this Sep 3, 2021
@remcowesterhoud remcowesterhoud mentioned this issue Sep 6, 2021
Merged
9 tasks
ghost pushed a commit that referenced this issue Sep 8, 2021
@remcowesterhoud
merge: #7764
fc340b5 
7764: fix(engine): Added null-check to ProcessMessageStartEventMessageNameValidator r=remcowesterhoud a=remcowesterhoud

## Description

Fix for NPE during validation of new deployment.

## Related issues

closes #5510 



Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@ghost ghost closed this as completed in 6a7b6fb Sep 8, 2021
Zeebe automation moved this from Planned to Done Sep 8, 2021
@saig0 saig0 mentioned this issue Sep 9, 2021
Closed
@github-actions github-actions bot mentioned this issue Sep 9, 2021
Merged
ghost pushed a commit that referenced this issue Sep 9, 2021
@remcowesterhoud
merge: #7791
6648153 
7791: [Backport stable/1.1] fix(engine): Added null-check to ProcessMessageStartEventMessageNameValidator r=remcowesterhoud a=github-actions[bot]

# Description
Backport of #7764 to `stable/1.1`.

relates to #5510

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@remcowesterhoud remcowesterhoud mentioned this issue Sep 9, 2021
Merged
ghost pushed a commit that referenced this issue Sep 9, 2021
@remcowesterhoud
merge: #7793
6d8c01a 
7793: Backport 7764 to stable/1.0 r=saig0 a=remcowesterhoud

## Description

Backport of #7764 to stable/1.0.

ProcessValidationUtil class did not exist yet in the stable branch. I had changes so I needed to add this class to resolve the conflict.

## Related issues

relates to #5510

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
ghost pushed a commit that referenced this issue Sep 9, 2021
@remcowesterhoud
merge: #7791
3cffcba 
7791: [Backport stable/1.1] fix(engine): Added null-check to ProcessMessageStartEventMessageNameValidator r=remcowesterhoud a=github-actions[bot]

# Description
Backport of #7764 to `stable/1.1`.

relates to #5510

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@KerstinHebel KerstinHebel removed this from Done in Zeebe Mar 23, 2022
github-merge-queue bot pushed a commit that referenced this issue Mar 14, 2024
@renovate
chore(deps): update dependency @carbon/elements to v11.31.0 (#5510)
4fcc6d6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remcowesterhoud remcowesterhoud

Labels
kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user support Marks an issue as related to a customer support request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(engine): Added null-check to ProcessMessageStartEventMessageNameValidator camunda/camunda
5 participants
@npepinpe @deepthidevaki @saig0 @remcowesterhoud @pihme