Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate proto file #6117

Merged
1 commit merged into from
Jan 18, 2021
Merged

Regenerate proto file #6117

1 commit merged into from
Jan 18, 2021

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Jan 15, 2021

Description

Regenerate proto file related to #6105. I seem to miss it after the review to regenerate the proto 🙄 sorry

Related issues

closes #

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

 Regenerate proto file related to #6105
@Zelldon Zelldon requested a review from saig0 January 15, 2021 14:26
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@saig0
Copy link
Member

saig0 commented Jan 18, 2021

bors r+

@ghost
Copy link

ghost commented Jan 18, 2021

Build succeeded:

@ghost ghost merged commit 982a4a8 into develop Jan 18, 2021
@ghost ghost deleted the zell-fixup-6105 branch January 18, 2021 06:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants