Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit creating an event subscription if no event can be triggered #6215

Merged
1 commit merged into from
Feb 1, 2021

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jan 28, 2021

Description

  • don't create an event subscription (i.e. an event trigger) for an activity if no event can be triggered (i.e. no boundary events)
  • it is a preparation for Restore event subscriptions on replay #6200
  • there is no test to verify that the subscription is not created because
    • currently, we don't have stream processor tests that verify the state directly
    • the impact is very low
    • it will be tested indirectly later when verifying the replay

Related issues

closes #6201

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

* don't create an event subscription if no event can be triggered for the activity
@saig0 saig0 requested a review from korthout January 28, 2021 08:28
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, (after discussing): Please also do this for unsubscribe event

@saig0
Copy link
Member Author

saig0 commented Feb 1, 2021

It would make sense to avoid the lookup if no events can be triggered. But it is not a trivial change (i.e. more refactoring required to make it work for interrupting event subprocesses). Since it would be an improvement to the current situation, we can postpone it for now 😅

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, LGTM 🎉

@saig0
Copy link
Member Author

saig0 commented Feb 1, 2021

bors r+

@ghost
Copy link

ghost commented Feb 1, 2021

Build succeeded:

@ghost ghost merged commit 514c574 into develop Feb 1, 2021
@ghost ghost deleted the 6201-event-subscription branch February 1, 2021 15:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omit creating an event subscription if no event can be triggered
3 participants