-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(zb-db): introduce RocksDBConfig and made statistics optional #6246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This means the ColumnFamilyType
of the ZeebeDbFactory
is now inferred via return type? But then the DB it produces will have the right type. I don't see any downsides, I guess - I'm still thinking if we should keep the enums in general, but we can debate that later.
.setLogFileTimeToRoll(Duration.ofMinutes(30).toSeconds()) | ||
.setKeepLogFileNum(2) | ||
// can be disabled when not profiling | ||
.setStatsDumpPeriodSec(20); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be set only if statistics is enabled, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah makes probably sense 👍
You can create an follow up issue if you see a need. I think it makes it harder to use, if we not have the enum especially how will you differentiate between the different types to make sure that you are not iterating over variables and messages when searching for a job etc. |
@npepinpe I updated the PR please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks @npepinpe and now get some rest :) |
bors r+ |
Build succeeded: |
Description
Related issues
closes #6157
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: