Apply event-sourcing to the message start event subscription processors #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
force-pushed
the
6183-message-start-event-subscription
branch
from
06ace74
to
7e2e96e
Compare
saig0
force-pushed
the
6183-message-start-event-subscription
branch
from
7e2e96e
to
2e23d82
Compare
saig0
force-pushed
the
6183-message-start-event-subscription
branch
from
2e23d82
to
51d47ee
Compare
pihme
approved these changes
Mar 11, 2021
engine/src/main/java/io/zeebe/engine/processing/message/Subscriptions.java
Outdated
Show resolved
Hide resolved
|
|
||
| CLOSE((short) 2), | ||
| CLOSED((short) 3); | ||
| CREATED((short) 0), |
There was a problem hiding this comment.
One thing we might want to consider here is whether we want to reuse the old ordinals. E.g. if you set Correlated to 4 and deleted to 3, we could read more of the old records. Not sure there is a point though, as there are ordinals of the old records which we cannot read anymore anyway.
Another option is to keep all the old ordinals, reassign the reused ones, deprecate the ones we won't use anymore. Then we could write out exceptions when we encounter an unsupported ordinal.
Again, not sure it is worth it.
There was a problem hiding this comment.
Usually, I would agree. But since the version will not be compatible anyway, we don't need to care.
saig0
force-pushed
the
6183-message-start-event-subscription
branch
from
51d47ee
to
c7459a7
Compare
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 11, 2021
6510: Apply event-sourcing to the message start event subscription processors r=saig0 a=saig0 ## Description * align the message start event subscription intents `OPENED` and `CLOSE` and rename them to `CREATED` and `DELETED` * avoid writing and process `CREATE` and `DELETE` commands * instead, the deployment processor writes the events directly * replace the command processors by the event appliers ## Related issues closes #6183 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [ ] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually * [ ] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 11, 2021
6510: Apply event-sourcing to the message start event subscription processors r=saig0 a=saig0 ## Description * align the message start event subscription intents `OPENED` and `CLOSE` and rename them to `CREATED` and `DELETED` * avoid writing and process `CREATE` and `DELETE` commands * instead, the deployment processor writes the events directly * replace the command processors by the event appliers ## Related issues closes #6183 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [ ] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually * [ ] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
|
Build failed: |
* align the message start event subscription intents OPENED and CLOSED and rename them to CREATED and DELETED * avoid writing CREATE and DELETE commands. instead, write the events directly when processing a new deployment.
saig0
force-pushed
the
6183-message-start-event-subscription
branch
from
c7459a7
to
5d853e0
Compare
|
bors |
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 16, 2021
6510: Apply event-sourcing to the message start event subscription processors r=saig0 a=saig0 ## Description * align the message start event subscription intents `OPENED` and `CLOSE` and rename them to `CREATED` and `DELETED` * avoid writing and process `CREATE` and `DELETE` commands * instead, the deployment processor writes the events directly * replace the command processors by the event appliers ## Related issues closes #6183 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [ ] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually * [ ] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OPENEDandCLOSEand rename them toCREATEDandDELETEDCREATEandDELETEcommandsRelated issues
closes #6183
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: