Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backports stable/1.0] Fix intermittent build errors by removing buildnumber plugin #7405

Merged
3 commits merged into from
Jun 30, 2021
Merged

[Backports stable/1.0] Fix intermittent build errors by removing buildnumber plugin #7405

3 commits merged into from
Jun 30, 2021

Conversation

npepinpe
Copy link
Member

Description

This PR backports #7403 to stable/1.0. The only conflict was some import statements in Atomix.java since we simplified the partition groups in 1.1 but not in 1.0.

Related issues

relates to #7294

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@npepinpe
build(atomix): remove buildnumber plugin
184cbe7 
Removes the buildnumber plugin as it sometimes causes errors when
rebuilding without cleaning prior to it.

(cherry picked from commit f4b0e5c)
@npepinpe
refactor(atomix): remove usage of old build number plugin
ce7afcf 
Removes usage of build number plugin. For now replace version with a
hardcoded version.

(cherry picked from commit 725d809)
@npepinpe
refactor(atomix): use version property
38b47f6 
Replaces hard coded, temporary version for the version property as
parsed by VersionUtil and the rest of the project.

(cherry picked from commit 97aec3f)
@npepinpe npepinpe requested a review from pihme June 30, 2021 11:54
pihme
pihme approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@ghost
Copy link

ghost commented Jun 30, 2021

Build succeeded:

@ghost ghost merged commit 3e41ecd into stable/1.0 Jun 30, 2021
@ghost ghost deleted the backport-7403-to-stable/1.0 branch June 30, 2021 12:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pihme pihme pihme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@npepinpe @pihme