Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent build errors by removing buildnumber plugin #7403

Merged
3 commits merged into from
Jun 30, 2021

Conversation

npepinpe
Copy link
Member

Description

This PR removes the buildnumber plugin which is unmaintained, and was causing intermittent build errors when building the project without first cleaning. As we already package the project version, we don't need this plugin for now. We could consider eventually adding more versioned properties (e.g. git properties), but we should then use a maintained project such as git-commit-id.

Atomix uses the software version when comparing members as part of its membership algorithm - this was previously parsed from the buildnumber, but now was replaced by our standard VersionUtil.

Related issues

closes #7294

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

Removes the buildnumber plugin as it sometimes causes errors when
rebuilding without cleaning prior to it.
Removes usage of build number plugin. For now replace version with a
hardcoded version.
Replaces hard coded, temporary version for the version property as
parsed by VersionUtil and the rest of the project.
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@ghost
Copy link

ghost commented Jun 30, 2021

Build succeeded:

@ghost ghost merged commit d7e2879 into develop Jun 30, 2021
@ghost ghost deleted the 7294-build-error branch June 30, 2021 10:49
@github-actions
Copy link
Contributor

Backport failed for stable/1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.0
git worktree add -d .worktree/backport-7403-to-stable/1.0 origin/stable/1.0
cd .worktree/backport-7403-to-stable/1.0
git checkout -b backport-7403-to-stable/1.0
ancref=$(git merge-base 57f56406fbb6f645a828f99fc1baaefc46d6fb2c 97aec3f893a1b7f7ee99b1abf57c63d7f38be391)
git cherry-pick -x $ancref..97aec3f893a1b7f7ee99b1abf57c63d7f38be391

ghost pushed a commit that referenced this pull request Jun 30, 2021
7405: [Backports stable/1.0] Fix intermittent build errors by removing buildnumber plugin r=pihme a=npepinpe

## Description

This PR backports #7403 to stable/1.0. The only conflict was some import statements in `Atomix.java` since we simplified the partition groups in 1.1 but not in 1.0.

## Related issues

relates to #7294



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent build errors
2 participants