Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): non-utf8 symbol in the CONTRIBUTING.md #7952

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

aivinog1
Copy link
Contributor

@aivinog1 aivinog1 commented Oct 8, 2021

Description

I saw that in the contributing guide exists a non-UTF-8 symbol. Just replace it with a simple spacebar :)

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@npepinpe
Copy link
Member

Thanks 😄

@npepinpe npepinpe merged commit 215b1d5 into camunda:develop Oct 12, 2021
@aivinog1 aivinog1 deleted the non-utf-contributing branch October 12, 2021 08:36
@korthout korthout added the version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0 label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants