Expose Broker API to step down if not leader #8295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaschoenburg
force-pushed
the
8224-broker-api-step-down
branch
8 times, most recently
from
9ed493b
to
7ae8e4a
Compare
lenaschoenburg
force-pushed
the
8224-broker-api-step-down
branch
from
7ae8e4a
to
280452e
Compare
deepthidevaki
requested changes
Dec 1, 2021
broker/src/main/java/io/camunda/zeebe/broker/transport/adminapi/AdminApiRequestHandler.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/transport/adminapi/AdminApiRequestHandler.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/transport/adminapi/AdminApiRequestHandler.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/transport/adminapi/AdminApiRequestHandler.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/bootstrap/PartitionManagerStep.java
Show resolved
Hide resolved
Instead of using a partition listener to subscribe/unsubscribe based on becoming leader or follower we simply subscribe to admin requests on all partitions and never unsubscribe. The admin api handles requests on followers gracefully.
deepthidevaki
requested changes
Dec 1, 2021
transport/src/main/java/io/camunda/zeebe/transport/impl/AtomixServerTransport.java
Show resolved
Hide resolved
transport/src/main/java/io/camunda/zeebe/transport/impl/AtomixServerTransport.java
Show resolved
Hide resolved
|
bors r+ |
|
Build succeeded: |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces a new Admin API for the Broker. The only supported request so far is
STEP_DOWN_IF_NOT_LEADER.The handler has access to the Raft partitions by getting the partition manager injected after partitions are started.
The handler is a
PartitionListenerso it subscribes and unsubscribes to messages when it transitions between leader, follower and inactive. This is optional behavior and could be removed as thestepDownIfNotLeaderis a no-op when the broker is not the leader for this partition.Related issues
closes #8224
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: