Support documentation reference (#70) #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for documentationRef on Template and TemplateProperty Add support for description on Template
strangelookingnerd
force-pushed
the
feature/support-documentation-reference
branch
from
3da310c
to
f8ad37d
Compare
|
Thanks, for this pull request. This gives us another feature that we can cover with our annotations. |
strangelookingnerd
deleted the
feature/support-documentation-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
This PR adds support for
documentationRefonTemplateandTemplatePropertyWhile at it I also added support for
descriptionfield onTemplate.Tests have been adapted to validate the functionality.
IMHO: There are plenty of other fields defined in the
schema.jsonthat are currently not covered by the annotations / plugin. It may be worth to make it feature complete in the long run.