Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support #34

Merged
merged 5 commits into from
Aug 4, 2020
Merged

Proxy support #34

merged 5 commits into from
Aug 4, 2020

Conversation

domkun
Copy link
Contributor

@domkun domkun commented Jul 31, 2020

Adds proxy support for the communication between the plugin and the keycloak instance.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@domkun domkun mentioned this pull request Jul 31, 2020
Closed
VonDerBeck
VonDerBeck requested changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@VonDerBeck VonDerBeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good catch 👍
I have just a view simple remarks - it would be nice if these were solved

Thanks a lot :-)

extension/src/main/java/org/camunda/bpm/extension/keycloak/KeycloakIdentityProviderFactory.java Outdated Show resolved Hide resolved
extension/src/main/java/org/camunda/bpm/extension/keycloak/KeycloakIdentityProviderFactory.java Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@VonDerBeck
Copy link
Collaborator

@domkun Great, thanks a lot 👍

@VonDerBeck VonDerBeck merged commit a3c8385 into camunda-community-hub:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VonDerBeck VonDerBeck VonDerBeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@domkun @CLAassistant @VonDerBeck