Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to disable auto deployment for springboot? #35

Closed
vijamesDD opened this issue Sep 7, 2022 · 2 comments
Closed

Add configuration to disable auto deployment for springboot? #35

vijamesDD opened this issue Sep 7, 2022 · 2 comments

Comments

@vijamesDD
Copy link

vijamesDD commented Sep 7, 2022

For camunda-engine-rest-client-complete-springboot-starter package it would be helpful to have configuration that would allow a consumer of this package to disable the auto deployment that occurs on startup.

Potential configuration value camunda.autoDeploy.enabled would be supplied in the application properties and then used to determine if deployment should occur.

@vijamesDD
Copy link
Author

vijamesDD commented Sep 7, 2022

I tried to create a branch with this change for pull request but was unable to push branches to this repo.

I also couldn't figure out how to test changes on this repo locally - any ideas? I have a sample application locally that imports camunda-engine-rest-client-complete-springboot-starter as a dependency, which I could use to test it. I ran mvn package on this repo to create the jar, but was not able to load the jar as a dependancy into my sample application. The sample app would complain on compile saying "Could not find artifact"... any ideas would be appreciated, thanks!

@berndruecker
Copy link
Collaborator

Hey @vijamesDD - to create a PR you need to fork the repo and do the changes in a new branch in your own repo. Then you can create a PR against this one.

If you want to test the library locally, build it via maven install and then use the artifact in SNAPSHOT version - this does work (just make sure to install instead of package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants