Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryBackOff param for FailJobCommand #451

Conversation

Ileksa
Copy link

@Ileksa Ileksa commented Oct 20, 2022

In order to set backoff timeout parameter existing in grpc request I added retryBackOff parameter to FailJobCommand.

@Ileksa Ileksa requested a review from Zelldon as a code owner October 20, 2022 13:52
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! I was a while OOO.

Thanks for the contribution! Could you also add a test for it, please.

Furthermore, for the next time please have a look at the contribution guideline regarding git commit message guidelines.

@aanodin
Copy link
Contributor

aanodin commented Jan 9, 2023

👍
also interested in this one to be merged

@aanodin
Copy link
Contributor

aanodin commented Jan 9, 2023

created #482 with tests

@Zelldon
Copy link
Collaborator

Zelldon commented Jan 18, 2023

replaced by #482 thanks @aanodin

@Zelldon Zelldon closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants