feat: Update Testcontainers for .NET #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Awesome thanks for updating and improving it @HofmeisterAn I was always procrastinating this 🥇 Please sign our CLA and then I can merge it 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the Testcontainers for .NET NuGet dependency to its latest release. Assigns a random host port to the service running inside a container (best practice). Resolve the hostname instead of a fixed value (endpoint my differ due to the Docker environment, Testcontainers resolves the right endpoint).
Why is it important?
I noticed you are using an outdated version. The version is probably not compatible with Docker Desktop, etc. anymore. To leverage Testcontainesr into your test environment, I recommend the latest release.
If you have issues setting up Testcontinaers, let me know. I am happy to help. While I was browsing through the source code I noticed some parts that can be improved. I addressed some of them immediately.
Related issues
-