Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Emits ready when not ready #158

Closed
jwulf opened this issue Apr 11, 2020 · 1 comment
Closed

Emits ready when not ready #158

jwulf opened this issue Apr 11, 2020 · 1 comment

Comments

@jwulf
Copy link
Member

jwulf commented Apr 11, 2020

At the moment, trying an operation that fails causes the onReady event to fire.

This happens because I forced the client ready state to allow the worker to keep polling after the connection drops (for example, when the broker goes away then comes back).

This is going to require a refactor.

The polling operation can fail, but this should not prevent it polling again.
However, it should not emit ready.

So it needs two representations of ready. One is "ready to retry operation". This is when the channel state is IDLE or CONNECTED. The other is "ready to rock", this is when an operation returns a result.

The Middleware.Events.Ready should only be emitted in the second case, and we need the Internal signal for the first case.

jwulf added a commit to jwulf/zeebe-client-node-js that referenced this issue May 6, 2020
@jwulf
Copy link
Member Author

jwulf commented May 6, 2020

Fixed in 0.23.0

@jwulf jwulf closed this as completed May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant