Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

timeToLive documentation fix #311

Closed
nhomble opened this issue Apr 19, 2023 · 0 comments · Fixed by #313
Closed

timeToLive documentation fix #311

nhomble opened this issue Apr 19, 2023 · 0 comments · Fixed by #313

Comments

@nhomble
Copy link

nhomble commented Apr 19, 2023

Issue tracker is ONLY used for reporting bugs. New features and questions should be discussed on our slack channel.

Expected Behavior

In the library docs, timeToLive in the message publisher states

    /** The number of seconds for the message to buffer on the broker, awaiting correlation. Omit or set to zero for no buffering. */
    timeToLive: MaybeTimeDuration;

so I was expecting the argument to be optional (and defaulted to 0)

Current Behavior

There is a ts-compiler error because the argument is required.

Possible Solution

Add a ?

jwulf added a commit that referenced this issue May 2, 2023
@jwulf jwulf mentioned this issue May 2, 2023
@jwulf jwulf closed this as completed in #313 May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant