Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-loop Rule Detects False Positives #155

Open
philippfromme opened this issue Feb 14, 2024 · 1 comment
Open

no-loop Rule Detects False Positives #155

philippfromme opened this issue Feb 14, 2024 · 1 comment
Assignees
Labels
backlog Queued in backlog bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@philippfromme
Copy link
Collaborator

philippfromme commented Feb 14, 2024

The no-loop rule aims to detect potential loops. These can also include call activities. If a call activity calls its parent process, it can cause an endless loop. The no-loop rule mirrors the behavior of Zeebe and only reports an error if the called process ID is the same as the parent process ID. However, it also reports an error if the call activity is part of a potential loop regardless of the process it calls. This process deploys without errors:

image

Reported through Slack: https://camunda.slack.com/archives/C0693F1NFK5/p1707223390238339

Related to camunda/camunda#13056

@philippfromme philippfromme added the bug Something isn't working label Feb 14, 2024
@philippfromme philippfromme changed the title Do Not Report Potential False Positives When Detecting Loops no-loop Rule Detects False Positives Feb 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 15, 2024
@philippfromme philippfromme reopened this Feb 21, 2024
@philippfromme philippfromme added the in progress Currently worked on label Feb 21, 2024 — with bpmn-io-tasks
@philippfromme philippfromme added the ready Ready to be worked on label Mar 6, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Mar 6, 2024
@nikku nikku added the spring cleaning Could be cleaned up one day label Mar 14, 2024
@nikku
Copy link
Member

nikku commented Mar 14, 2024

Moving to backlog. Not our current focus.

@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
2 participants