-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add implementation rule #11
Conversation
The documentation does not include an image due to the fact that difference is not rendered on the diagram. This is also the reason why I resigned from the diagram examples and used code snippets instead. |
8c3aba5
to
2363188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments.
d00c99b
to
1ef5f9a
Compare
1ef5f9a
to
5a903bd
Compare
Got feedback from @ThorbenLindhauer that we should disallow missing implementation for the Message Throw/End Events. So this would be a way to promote best practices. From readme:
In that case, I think it makes sense to be more strict than the engine. |
Let's implement the strict message event definition validation (#11 (comment)) and we're good I think! |
5a903bd
to
6b1e1c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you removed most of the rough edges.
One thing I thought about: How much sense does it make to activate this rule in non-executable processes?
In BPMN we distinguish between these. Non executable processes are meant for documentation only and not picked up by the engine. I'd assume I can do anything in there, with no such limit.
Yeah, that makes sense. I haven't thought about it. I'll extend the test case to not bug the user about non-executable processes. |
5c5da98
to
908c0d2
Compare
Now we ignore non-executable processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 🍰 🎉
Closes #4