Fix: The deadline passed to 'waitForReady' in "GrpcClient", was a millisecond gap, but the method needs a date or a TS of the deadline #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"waitForReady" was called with a deadline of 10000 milliseconds. But the method 'watchConnectivityState' used by 'waitForReady', wants a deadline date. cf: https://github.com/grpc/grpc-node/blob/%40grpc/grpc-js%401.9.7/packages/grpc-js/src/internal-channel.ts#L739 So this fix is to set the deadline date at now + 10s
|
|
lsidoree
changed the title
jwulf
changed the title
jwulf
changed the title
jwulf
added a commit
that referenced
this pull request
May 6, 2024
|
Thanks for finding and fixing this @lsidoree. For future reference, pull requests should be made against the I can roll this fix into another patch - or if you'd like to submit a PR against |
|
Next time I'll read the contribution rules better, sorry! |
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
## [8.5.2](v8.5.1...v8.5.2) (2024-05-07) ### Bug Fixes * **zeebe:** waitForReady deadline not miliseconds, but date ([#148](#148)) ([12db206](12db206)) ### Features * **repo:** add CAMUNDA_CUSTOM_ROOT_CERT_STRING parameter ([7451a66](7451a66)), closes [#151](#151) [#150](#150) [#146](#146) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) ### Reverts * Revert "fix(zeebe): waitForReady deadline not miliseconds, but date (#148)" (#149) ([f8c0c7d](f8c0c7d)), closes [#148](#148) [#149](#149)
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
## [8.5.2](v8.5.1...v8.5.2) (2024-05-07) ### Bug Fixes * **zeebe:** waitForReady deadline not miliseconds, but date ([#148](#148)) ([12db206](12db206)) ### Features * **repo:** add CAMUNDA_CUSTOM_ROOT_CERT_STRING parameter ([7451a66](7451a66)), closes [#151](#151) [#150](#150) [#146](#146) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) [#151](#151) [#150](#150) [#142](#142) ### Reverts * Revert "fix(zeebe): waitForReady deadline not miliseconds, but date (#148)" (#149) ([f8c0c7d](f8c0c7d)), closes [#148](#148) [#149](#149)
|
Thank you for finding and fixing this @lsidoree. This has been a bug in the zeebe client for the last five years. How did you find it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"waitForReady" was called with a deadline of 10000 milliseconds.
But the method 'watchConnectivityState' used by 'waitForReady', needs a deadline date.
cf: https://github.com/grpc/grpc-node/blob/%40grpc/grpc-js%401.9.7/packages/grpc-js/src/internal-channel.ts#L739
This caused to throw error "Deadline passed without connectivity state change" in "watchConnectivityState" every time.
So this fix is to set the deadline date at now + 10s