Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input sanitization of URL attributes #2573

Open
ThorbenLindhauer opened this issue Sep 1, 2021 · 0 comments
Open

Improve input sanitization of URL attributes #2573

ThorbenLindhauer opened this issue Sep 1, 2021 · 0 comments
Labels
scope:webapp Changes to all the webapps. type:task Issues that are a change to the project that is neither a feature nor a bug fix.

Comments

@ThorbenLindhauer
Copy link
Member

This issue was imported from JIRA:

Field Value
JIRA Link CAM-13877
Reporter @marstamm
Has restricted visibility comments false

Currently, the information in the URL is treated as safe. This is not best practice.

Acceptance Criteria (Required on creation):

  • Sanitize all URL components (path and query parameters) before accessing the data

Hints (Optional):

Options:

  • Patch the routeProvider and locationProvider to escape dangerous strings on access
    Pro: all access using angular services covered
    Con: access over window.location not covered, patching angular internals might be tricky

  • Create a URL watcher that replaces the URL as changes are made
    Pro: All access is covered
    Con: Might cause a feedback loop with other watchers

Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:webapp Changes to all the webapps. type:task Issues that are a change to the project that is neither a feature nor a bug fix.
Projects
None yet
Development

No branches or pull requests

1 participant