Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Behavior that Updates camunda:formData#businessKey on ID Change or Removal of Referenced Form Field #48

Closed
Tracked by #2
philippfromme opened this issue Sep 16, 2021 · 0 comments
Closed
Tracked by #2

Implement Behavior that Updates camunda:formData#businessKey on ID Change or Removal of Referenced Form Field #48

philippfromme opened this issue Sep 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Sep 16, 2021 •
edited
Loading

When removing a camunda:FormField or changing its ID the camunda:FormData's camunda:businessKey has to be updated.

ID change

Before:

<bpmn:userTask id="Activity_1">
  <bpmn:extensionElements>
    <camunda:formData businessKey="FormField_1">
      <camunda:formField id="FormField_1" />
    </camunda:formData>
  </bpmn:extensionElements>
</bpmn:userTask>

After:

<bpmn:userTask id="Activity_1">
  <bpmn:extensionElements>
    <camunda:formData businessKey="FormField_2">
      <camunda:formField id="FormField_2" />
    </camunda:formData>
  </bpmn:extensionElements>
</bpmn:userTask>

Removal

Before:

<bpmn:userTask id="Activity_1">
  <bpmn:extensionElements>
    <camunda:formData businessKey="FormField_1">
      <camunda:formField id="FormField_1" />
      <camunda:formField id="FormField_2" />
    </camunda:formData>
  </bpmn:extensionElements>
</bpmn:userTask>

After:

<bpmn:userTask id="Activity_1">
  <bpmn:extensionElements>
    <camunda:formData>
      <camunda:formField id="FormField_2" />
    </camunda:formData>
  </bpmn:extensionElements>
</bpmn:userTask>

Child of bpmn-io/bpmn-properties-panel#2
@philippfromme philippfromme added the enhancement New feature or request label Sep 16, 2021
philippfromme added a commit that referenced this issue Sep 16, 2021
@philippfromme
feat(camunda-platform): update/remove business key
17ba062 
* update business key if form field ID is updated
* remove business key if form field is removed

Closes #48
This was referenced Sep 16, 2021
Merged
Closed
@philippfromme philippfromme added the needs review Review pending label Sep 21, 2021 — with bpmn-io-tasks
@MaxTru MaxTru closed this as completed in 54d403b Sep 23, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philippfromme