Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CHANGELOG): update to v1.0.0 #225

Merged
merged 1 commit into from
Jan 2, 2023
Merged

chore(CHANGELOG): update to v1.0.0 #225

merged 1 commit into from
Jan 2, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Jan 2, 2023

Related to #216

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 2, 2023
@smbea smbea requested review from a team, philippfromme and marstamm and removed request for a team January 2, 2023 09:30
@smbea
Copy link
Contributor Author

smbea commented Jan 2, 2023

@marstamm @philippfromme could one of you have a look 🙏? Would love to move forward with this soon

Comment on lines +11 to +12
* `DEPS`: update to `bpmn-js@11.1.0`
* `DEPS`: update to `diagram-js@11.4.1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As camunda-bpmn-js is the entry point for other tools to integrate bpmn-js, the changelog should also contain noteworthy changes from the upstream libs. I see that we only explicitly mention changes made in camunda-bpmn-js.

Are there changes that impact the integration in the new bpmn-js or diagram-js versions? If there are only small changes in the new versions, I'm fine to release as-is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there aren't any big changes. I added the replace menu shortcut that was added in bpmn-js because it seems impactful, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's merge 👍

@smbea smbea merged commit 65eb011 into main Jan 2, 2023
@smbea smbea deleted the update-to-1.0.0 branch January 2, 2023 10:19
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants