Fix Extension #46
Fix Extension #46
Conversation
philippfromme
force-pushed
the
45-fix-extension
branch
4 times, most recently
from
fc5d916
to
f00891e
Compare
philippfromme
added
needs review
There was a problem hiding this comment.
As we're refactoring this extension, could we migrate it to ES6 on the fly, too?
Am I correct in the assumption that this change is a BREAKING one? If so, please write that in the commit. And please reference the issue you're closing in the commit message, too.
test/spec/extension.js
Outdated
| }); | ||
|
|
||
| }); | ||
| 'use strict'; |
There was a problem hiding this comment.
Did you by accident convert this to Windows line endings?
There was a problem hiding this comment.
Yes, don't ask me how that happened.
|
With this thing being merged we should double check the existing copy and paste issues to see if we can close some. |
Good idea.
It is breaking in the sense that it's now working and it previously wasn't. |
philippfromme
force-pushed
the
45-fix-extension
branch
from
f00891e
to
ff8bd5c
Compare
* listener wasn't returning anything * check for allowed parent elements Requires bpmn-io/bpmn-js#1137
philippfromme
force-pushed
the
45-fix-extension
branch
from
ff8bd5c
to
73fc024
Compare
Not required anymore with bpmn-moddle@6
Requires bpmn-io/bpmn-js#1141
Closes #45