-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-clients/grpc): add variables argument for FailJob gRPC #1388
Conversation
56c3188
to
7a0e98f
Compare
Hi, @korthout, I've updated the doc, Please review this, Thank you. |
Thanks @skayliu ❤️ , I'll have a look at this in the coming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skayliu 🚀
This change made me wonder whether we also need to update:
❓ But I'm not sure, because that page explains the basic job worker concept while this feature is for rather advanced use cases. I'd be curious to hear your opinion about this.
🔧 Please consider my suggestion
@korthout what you think add these? When
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No adjustments from a technical writing perspective on this one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional changes @skayliu
@christinaausley Let me know what you think about linking ahead in the concepts and about my grammar suggestion.
a074a98
to
d767c4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏅
What is the purpose of the change
Add variables argument for FailJob gRPC.
closes #1387
Are there related marketing activities
No.
When should this change go live?
May be C8.2.
PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory, or they are not for future versions.